Conversation
|
This pull request introduces 12 alerts and fixes 21 when merging ceb9e76 into 4e90768 - view on LGTM.com new alerts:
fixed alerts:
|
Collaborator
|
Unfortunately, we fixed it simultaniusly but there are additional fixes in #507. Pleases review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
yarn 3.1.0 under Node 16.17.0 LTS was failing with:
This was due to yarn 3 relying on experimental custom ESM loaders, which can have breaking changes in minor versions. The issue was discussed and resolved here.
What was done?
This PR updates yarn to a version 3.2.2, which supports the changes to ESM loaders in Node 16.17.x (and Node 18.x)
How Has This Been Tested?
Locally
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only