feat: create withdrawal keys for masternode identities #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
March 10, 2022 17:10
# Conflicts: # packages/platform-test-suite/test/functional/platform/Identity.spec.js
added 6 commits
April 29, 2022 18:00
shumkov
reviewed
May 2, 2022
packages/js-drive/lib/identity/masternode/handleUpdatedScriptPayoutFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
May 2, 2022
packages/js-drive/lib/identity/masternode/synchronizeMasternodeIdentitiesFactory.js
Outdated
Show resolved
Hide resolved
…ayoutFactory.js Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
added 11 commits
May 2, 2022 17:29
# Conflicts: # packages/platform-test-suite/lib/test/createClientWithFundedWallet.js
# Conflicts: # .pnp.cjs # packages/dapi/package.json # packages/dashmate/package.json # packages/js-dapi-client/package.json # packages/js-dash-sdk/package.json # packages/js-dpp/package.json # packages/js-drive/package.json # packages/platform-test-suite/package.json # packages/wallet-lib/package.json # yarn.lock
# Conflicts: # .pnp.cjs # packages/bench-suite/package.json # yarn.lock
shumkov
approved these changes
May 4, 2022
Merged
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Create withdrawal keys for masternode owners and operators
What was done?
Add payout address and operator payout address keys with purpose “withdrawal” to identities to allow masternodes and operators withdraw L2 rewards (sign withdrawal state transition) using the same keys that they use to receive L1 rewards.
How Has This Been Tested?
With tests
Breaking Changes
Won't work with previous version of Core and dashcore-lib
Checklist:
For repository code-owners and collaborators only