fix(drive): fix group action query target as tree in stateless execution

[QuantumExplorer]

Issue being fixed or feature implemented

Updated query targets in the drive fetch action to use QueryTargetTree for better accuracy and clarity.

What was done?

• Changed the query target from QueryTargetValue(8) to QueryTargetTree(33, TreeType::SumTree) in fetch_action_id_signers_power.
• Enhanced error messages in grove_get_big_sum_tree_total_value, grove_get_optional_sum_tree_total_value, and grove_get_sum_tree_total_value to specify the context of the error more clearly.

How Has This Been Tested?

Changes have been tested with existing unit tests that cover the affected functionalities.

Breaking Changes

None

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes

  • Improved error messages for certain operations to provide more context when non-tree query targets are encountered.

• Refactor

  • Adjusted internal logic to use a tree structure for specific queries, enhancing data handling for sum tree operations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the construction of a query target in the group action signers power fetch logic to use a sum tree structure instead of a fixed-size value. Additionally, error messages in several GroveDB sum tree value retrieval functions are clarified to include the function name where the error occurs.

Changes

File(s)	Change Summary
packages/rs-drive/src/drive/group/fetch/fetch_action_id_signers_power/v0/mod.rs	Modified query target construction in fetch_action_id_signers_power_and_add_operations_v0 to use a sum tree.
packages/rs-drive/src/util/grove_operations/grove_get_big_sum_tree_total_value/v0/mod.rs packages/rs-drive/src/util/grove_operations/grove_get_optional_sum_tree_total_value/v0/mod.rs packages/rs-drive/src/util/grove_operations/grove_get_sum_tree_total_value/v0/mod.rs	Updated error messages to specify the function name when a non-tree query target is encountered.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant FetchModule as fetch_action_id_signers_power
    participant GroveOperations

    Caller->>FetchModule: fetch_action_id_signers_power_and_add_operations_v0()
    FetchModule->>GroveOperations: Query sum tree with QueryTargetTree(33, SumTree)
    GroveOperations-->>FetchModule: Return sum tree value or error with function context
    FetchModule-->>Caller: Return result

Loading

Possibly related PRs

• feat: group queries #2432: Modifies group action signers queries and related methods, directly affecting the same data fetching logic as this PR.

Suggested labels

dapi-endpoint

Suggested reviewers

• shumkov
• pauldelucia

Poem

A bunny hopped through sum tree land,
With queries now more clearly planned.
Error strings now tell their tale,
Of where things went a bit off-trail.
From fixed-size bytes to trees so grand,
The code now hops just as it’s planned!
🐇🌳

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8165601 and 650de93.

📒 Files selected for processing (4)

• packages/rs-drive/src/drive/group/fetch/fetch_action_id_signers_power/v0/mod.rs (2 hunks)
• packages/rs-drive/src/util/grove_operations/grove_get_big_sum_tree_total_value/v0/mod.rs (1 hunks)
• packages/rs-drive/src/util/grove_operations/grove_get_optional_sum_tree_total_value/v0/mod.rs (1 hunks)
• packages/rs-drive/src/util/grove_operations/grove_get_sum_tree_total_value/v0/mod.rs (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[QuantumExplorer]

Self Reviewed.