build: bump wasm-bindgen to 0.2.100 to satisfy js-sys deps #2503
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis pull request updates the version of the Changes
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Cargo.toml (2)
32-32: Token History Contract Addition with Trailing CommaThe inclusion of
"packages/token-history-contract",(with a trailing comma) enhances future maintainability by making it easy to add new members later. Please verify that the corresponding package exists and is configured correctly.
41-44: Intentional Disabling of Tower PatchesThe
[patch.crates-io]section now has the lines fortower-service,tower-layer, andtowercommented out. Confirm that this change is intentional to prevent these patches from being applied. If these patches are no longer needed, you might consider removing them entirely for a cleaner configuration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (19)
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (rs-dapi-client) / Formatting
- GitHub Check: Rust packages (rs-dapi-client) / Linting
- GitHub Check: Rust packages (rs-dapi-client) / Tests
- GitHub Check: Rust packages (rs-dapi-client) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (rs-dapi-client) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (dpns-contract) / Linting
- GitHub Check: Rust packages (wallet-utils-contract) / Tests
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust crates security audit
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(2 hunks)packages/rs-drive/Cargo.toml(3 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/rs-dpp/Cargo.toml
- packages/rs-drive-proof-verifier/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpp) / Unused dependencies
- GitHub Check: Rust packages (dpp) / Formatting
- GitHub Check: Rust packages (dpp) / Tests
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dashpay-contract) / Tests
- GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Linting
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (rs-dapi-client) / Tests
- GitHub Check: Rust packages (rs-dapi-client) / Check each feature
- GitHub Check: Rust packages (rs-dapi-client) / Linting
- GitHub Check: Rust packages (rs-dapi-client) / Formatting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (6)
packages/rs-platform-value/Cargo.toml (1)
10-12: Exact version pin for bincode dependency updated.
Enforcing the exact version (=2.0.0-rc.3) for thebincodedependency improves build reproducibility and consistency across the project. Verify that all consumers of this crate are compatible with this specific version.packages/rs-drive-abci/Cargo.toml (1)
16-18: Bincode version pinned to an exact version.
Locking thebincodedependency to=2.0.0-rc.3ensures uniform dependency resolution across modules. Confirm that this strict version requirement aligns with downstream integrations.packages/rs-platform-serialization/Cargo.toml (1)
10-12: Bincode dependency updated to an exact version.
Pinningbincodeto=2.0.0-rc.3prevents unintentional upgrades and aids in maintaining consistency between related packages.packages/rs-drive/Cargo.toml (2)
16-18: Exact bincode version enforced in dependencies.
Changing to=2.0.0-rc.3for thebincodedependency guarantees strict alignment with the rest of the codebase. Ensure this change is compatible with all integration points.
120-125: Improved formatting for the verify feature list.
Reformatting theverifyfeature as a multi-line array enhances readability and maintainability without affecting functionality.packages/simple-signer/Cargo.toml (1)
9-11: Bincode dependency version pin updated.
Specifying=2.0.0-rc.3forbincodealigns this package with the project-wide dependency management strategy, ensuring consistency across modules.
lklimek
force-pushed
the
deps/wasm-bindgen-0.2.100
branch
from
34cf457 to
33ab5e1
Compare
Issue being fixed or feature implemented
GHA failure due to js-sys requiring wasm-bindgen =0.2.100
What was done?
Updated wasm-bindgen to 0.2.100
How Has This Been Tested?
GHA
Breaking Changes
New version of wasm-bindgen-cli required to build
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit