fix: cookie accepts cookie name, path, and domain with out of bounds characters

[shumkov]

Issue being fixed or feature implemented

└─ cookie
   ├─ ID: 1099846
   ├─ Issue: cookie accepts cookie name, path, and domain with out of bounds characters
   ├─ URL: https://github.com/advisories/GHSA-pxg6-pf52-xh8x
   ├─ Severity: low
   ├─ Vulnerable Versions: <0.7.0
   │ 
   ├─ Tree Versions
   │  └─ 0.4.1
   │ 
   └─ Dependents
      └─ engine.io@npm:6.4.2

What was done?

• Updated cookie to >0.7.0

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• New Features

  • Updated the cookie package to version 0.7.1, enhancing functionality and performance.
  • Added a new development dependency for improved cookie handling.

• Bug Fixes

  • Resolved issues related to the previous version of the cookie package.

• Chores

  • Updated project version to 1.4.0-dev.3.

[coderabbitai]

Walkthrough

The changes include an update to the cookie package version in the .pnp.cjs file, where the version is changed from 0.4.1 to 0.7.1. This update affects both the package location and the dependency reference. Additionally, in the package.json file, the project version is updated to 1.4.0-dev.3, and a new dependency on cookie version ^0.7.0 is added to the devDependencies section.

Changes

File	Change Summary
.pnp.cjs	Updated cookie package version from 0.4.1 to 0.7.1 in RAW_RUNTIME_STATE. Updated package location.
package.json	Updated project version to 1.4.0-dev.3. Added new dependency "cookie": "^0.7.0" in devDependencies.

Poem

In the garden where cookies grow,
A version change we now bestow.
From 0.4 to 0.7 bright,
Our project hops with pure delight!
With every update, we leap and cheer,
For better code is always near! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

.pnp.cjs (1)

Line range hint 8272-9368: Consider adding tests to verify the fix.

While the cookie package has been successfully updated to address the vulnerability, the PR objectives mention that no additional tests were conducted. Consider adding tests to verify that the fix resolves the issue with cookie names, paths, and domains containing out-of-bounds characters.

Would you like assistance in generating test cases for this scenario?

package.json (1)

94-95: Summary of changes and their implications

1. The addition of "cookie": "^0.7.0" addresses the vulnerability mentioned in the PR objectives. This update ensures that the project uses a version of the cookie package that is not affected by the reported security issue.

2. The inclusion of "path-to-regexp": "^1.9.0" requires clarification as it's not mentioned in the PR objectives.

These changes in the resolutions section will ensure that these specific versions (or compatible ones) are used throughout the project, overriding any conflicting versions that might be required by other dependencies.

Please note that while these changes address the immediate security concern, it's important to regularly update dependencies and monitor for any new vulnerabilities that may be reported in the future.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8773afa and 8c3af90.

⛔ Files ignored due to path filters (3)

• .yarn/cache/cookie-npm-0.4.1-cc5e2ebb42-0f2defd60a.zip is excluded by !**/.yarn/**, !**/*.zip
• .yarn/cache/cookie-npm-0.7.1-f01524ff99-aec6a6aa07.zip is excluded by !**/.yarn/**, !**/*.zip
• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (2)

• .pnp.cjs (2 hunks)
• package.json (1 hunks)

🔇 Additional comments (4)

.pnp.cjs (2)

9368-9368: LGTM: Dependency reference updated consistently.

The dependency reference to the cookie package has been correctly updated to version 0.7.1, maintaining consistency with the earlier change.

---

8272-8275: LGTM: Cookie package updated to address vulnerability.

The cookie package has been successfully updated to version 0.7.1, which addresses the vulnerability mentioned in the PR objectives (affecting versions below 0.7.0). The package location in the cache has also been updated accordingly.

Let's verify that this update is consistent throughout the file:

✅ Verification successful

Verification Passed: Cookie package update is consistent across .pnp.cjs.

All references to the old version (0.4.1) have been successfully removed. The cookie package has been updated to version 0.7.1, and the package location is consistent throughout the file.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify cookie package version update consistency

# Test 1: Check for any remaining references to the old version
echo "Checking for old version references:"
rg '"cookie", "npm:0.4.1"' .pnp.cjs

# Test 2: Confirm all references are updated to the new version
echo "Confirming new version references:"
rg '"cookie", "npm:0.7.1"' .pnp.cjs

# Test 3: Check for any inconsistencies in package location
echo "Checking package location consistency:"
rg 'cookie-npm-0\.7\.1-f01524ff99-aec6a6aa07\.zip' .pnp.cjs

Length of output: 566

package.json (2)

95-95: LGTM: Addition of "cookie" package addresses the vulnerability.

The addition of "cookie": "^0.7.0" in the resolutions section aligns with the PR objectives. This update addresses the vulnerability (ID 1099846) affecting versions of the cookie package below 0.7.0.

---

94-94: Clarify the addition of "path-to-regexp" package.

The addition of "path-to-regexp": "^1.9.0" to the resolutions section is not mentioned in the PR objectives. Could you please explain the reason for including this package and confirm if it's related to the current PR's scope?