feat(dapi): add totalCreditsInPlatform endpoint
#2051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/platform into feat/totalCreditsOnPlatformQuery
pshenmic
requested changes
Aug 14, 2024
packages/js-dapi-client/lib/methods/platform/PlatformMethodsFacade.js
Outdated
Show resolved
Hide resolved
...pi-client/lib/methods/platform/getTotalCreditsOnPlatform/getTotalCreditsOnPlatformFactory.js
Outdated
Show resolved
Hide resolved
shumkov
changed the title
shumkov
changed the title
totalCreditsInPlatform endpoint
|
@owl352 Thank you for your PR. Please fix conflicts and then we can run CI |
…sOnPlatformQuery # Conflicts: # packages/js-dapi-client/lib/methods/platform/getTotalCreditsInPlatform/GetTotalCreditsInPlatformResponse.js
6 tasks
|
Closing in favor of #2059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Currently the getTotalCredits method cannot be called in js-dapi-client, moreover, even if it is prescribed, the implementation of the method call inside the module is not complete
What was done?
The method has been added to PlatformPromiseClient and PlatformMethodsFacade. A number of changes were also made to the function names
How Has This Been Tested?
Manual testing was performed on a local node built from source code
Breaking Changes
No breaking changes
Checklist:
For repository code-owners and collaborators only