chore(dapi)!: disable unnecessary for v1 endpoints #1857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To ensure attack resistance for DAPI we need to disable endpoints what we don't need for Platfrom v1. In future versions these endpoints will be revisited to make sure that they are secure and enabled back.
What was done?
generateToAddress
endpointgetBlock
is marked as unimplementedgetMasternodeStatus
is marked as unimplementedHow Has This Been Tested?
None
Breaking Changes
getBlock
andgetMasternodeStatus
maked as unimplemented for v1. It will be reconsidered in future versionsChecklist:
For repository code-owners and collaborators only