Skip to content

chore(dapi)!: disable unnecessary for v1 endpoints #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 24, 2024

Issue being fixed or feature implemented

To ensure attack resistance for DAPI we need to disable endpoints what we don't need for Platfrom v1. In future versions these endpoints will be revisited to make sure that they are secure and enabled back.

What was done?

  • Remove generateToAddress endpoint
  • getBlock is marked as unimplemented
  • getMasternodeStatus is marked as unimplemented

How Has This Been Tested?

None

Breaking Changes

getBlock and getMasternodeStatus maked as unimplemented for v1. It will be reconsidered in future versions

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner May 24, 2024 09:13
@shumkov shumkov changed the title chore/dapi/disable-endpoints chore(dapi)!: disable unnecessary for v1 endpoints May 24, 2024
@shumkov shumkov force-pushed the chore/dapi/disable-endpoints branch from 4e83422 to 3c4243b Compare May 28, 2024 03:47
@shumkov shumkov merged commit 5caf216 into v1.0-dev May 28, 2024
21 checks passed
@shumkov shumkov deleted the chore/dapi/disable-endpoints branch May 28, 2024 10:56
@thephez thephez added the dapi-endpoint DAPI endpoint addition or modification label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapi-endpoint DAPI endpoint addition or modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants