Skip to content

feat(dpp): random documents based on JSON schema #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2024

Conversation

fominok
Copy link
Collaborator

@fominok fominok commented Feb 22, 2024

Issue being fixed or feature implemented

Adds a method under a feature flag for DocumentType to generate random documents using json-schema-faker-rs solution

What was done?

Since jsonschema taken from DocumentType is not fully defined at one place as a self-contained schema, this PR wraps a json-schema-faker-rs part into manual tweaks to be able to go from json-schema-faker-rs output to an actual Document.

How Has This Been Tested?

There is a test.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat: random documents from jsonschema feat(dapi): random documents from jsonschema May 22, 2024
@shumkov shumkov changed the title feat(dapi): random documents from jsonschema feat(dpp): random documents from jsonschema May 22, 2024
@fominok fominok force-pushed the fix/create-document-verification-fix branch from 4b8bdaf to 4b5ce32 Compare May 22, 2024 09:48
@fominok fominok requested a review from shumkov May 22, 2024 09:49
@shumkov shumkov changed the title feat(dpp): random documents from jsonschema feat(dpp): random documents based on JSON schema May 22, 2024
shumkov
shumkov previously approved these changes May 22, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fominok fominok requested a review from shumkov May 22, 2024 16:13
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fominok fominok merged commit ff8e7c5 into v1.0-dev May 22, 2024
119 checks passed
@fominok fominok deleted the fix/create-document-verification-fix branch May 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants