-
Notifications
You must be signed in to change notification settings - Fork 43
feat(dpp): random documents based on JSON schema #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
shumkov
requested changes
May 22, 2024
shumkov
requested changes
May 22, 2024
4b8bdaf
to
4b5ce32
Compare
6 tasks
shumkov
previously approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
shumkov
reviewed
May 22, 2024
packages/rs-dpp/src/data_contract/document_type/v0/random_document.rs
Outdated
Show resolved
Hide resolved
shumkov
requested changes
May 22, 2024
packages/rs-dpp/src/data_contract/document_type/v0/random_document.rs
Outdated
Show resolved
Hide resolved
shumkov
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Adds a method under a feature flag for
DocumentType
to generate random documents usingjson-schema-faker-rs
solutionWhat was done?
Since jsonschema taken from
DocumentType
is not fully defined at one place as a self-contained schema, this PR wraps a json-schema-faker-rs part into manual tweaks to be able to go from json-schema-faker-rs output to an actualDocument
.How Has This Been Tested?
There is a test.
Breaking Changes
Checklist:
For repository code-owners and collaborators only