Skip to content

fix: make strategy tests compatible with all networks and platform tui #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 22, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Feb 21, 2024

Issue being fixed or feature implemented

Strategy tests only worked on mock chains before. Now they work on any network. Plus they are now compatible with Platform TUI.

What was done?

Mainly changes in the Strategy Tests library and resulting necessary changes in other files. Also random_document_type function now actually populates the schema field based on the other fields.

How Has This Been Tested?

By running strategy tests in Platform TUI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia marked this pull request as ready for review February 22, 2024 09:17
@pauldelucia pauldelucia changed the title Fix strategies 3 feat: strategy tests Feb 22, 2024
@pauldelucia pauldelucia changed the title feat: strategy tests fix: strategy tests Feb 22, 2024
@kxcd
Copy link

kxcd commented Feb 22, 2024

Good job !

@pauldelucia pauldelucia changed the title fix: strategy tests fix: make strategy tests compatible with all networks and platform tui Feb 22, 2024
@QuantumExplorer QuantumExplorer merged commit a988e69 into v1.0-dev Feb 22, 2024
@QuantumExplorer QuantumExplorer deleted the fix-strategies-3 branch February 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants