Skip to content

fix: broadcasting already invalidated transitions #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jan 12, 2024

Issue being fixed or feature implemented

There are always few transaction that was already included in a bock before and marked as invalid apperaing on other nodes after that block was finaized means they won't be removed. With a big network the number of such ghost invalid transactions in growing and ping ponging between nodes. We shouldn't allow to broadcast already invaidated txs

What was done?

  • Enable cache for invaid txs to prevent propagain of them

How Has This Been Tested?

We had this setting on a month ago and we didn't notice any ghost transactions

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title chore(dashmate): enable invalid tx cache for tenderdash chore(dashmate): do not allow to broadcast already invalidated transition Jan 12, 2024
@shumkov shumkov changed the title chore(dashmate): do not allow to broadcast already invalidated transition feat: do not allow to broadcast already invalidated transition Jan 12, 2024
@shumkov shumkov changed the title feat: do not allow to broadcast already invalidated transition feat: prevent of broadcasting already invalidated transitions Jan 12, 2024
@shumkov shumkov changed the title feat: prevent of broadcasting already invalidated transitions fix: broadcasting already invalidated transitions Jan 12, 2024
@shumkov shumkov merged commit f21ea2f into v1.0-dev Jan 12, 2024
@shumkov shumkov deleted the chore/dashmate/invalid-tx-cache branch January 12, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants