fix: broadcasting already invalidated transitions #1668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There are always few transaction that was already included in a bock before and marked as invalid apperaing on other nodes after that block was finaized means they won't be removed. With a big network the number of such ghost invalid transactions in growing and ping ponging between nodes. We shouldn't allow to broadcast already invaidated txs
What was done?
How Has This Been Tested?
We had this setting on a month ago and we didn't notice any ghost transactions
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only