feat(drive-abci)!: remove unnecessary validation from check tx and re-check #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
requested changes
Dec 28, 2023
...te_transition/state_transitions/identity/identity_create_transition/state_transition_like.rs
Outdated
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Outdated
Show resolved
Hide resolved
shumkov
changed the title
6 tasks
shumkov
requested changes
Jan 5, 2024
| use crate::execution::validation::state_transition::common::asset_lock::proof::verify_is_not_spent::AssetLockProofVerifyIsNotSpent; | ||
|
|
||
| // TODO: Versioning | ||
| impl AssetLockProofValidation for ChainAssetLockProof { |
| use crate::execution::validation::state_transition::common::asset_lock::proof::verify_is_not_spent::AssetLockProofVerifyIsNotSpent; | ||
|
|
||
| // TODO: Versioning | ||
| impl AssetLockProofValidation for InstantAssetLockProof { |
| impl AssetLockProofStateValidation for InstantAssetLockProof { | ||
| fn validate_state<C: CoreRPCLike>( | ||
| impl AssetLockProofVerifyIsNotSpent for InstantAssetLockProof { | ||
| fn verify_is_not_spent<C>( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Check tx used to have a pretty expensive validation. It wasn't always needed, especially on rechecks.
What was done?
While still verify some parts of state (for example the identity balance, or the fact that the asset lock hasn't been used), we no longer verify all parts of the state.
How Has This Been Tested?
Untested for now.
Breaking Changes
Because Check-tx is changing this can be considered a breaking change. It most likely would not break testnet however.
Checklist:
For repository code-owners and collaborators only