Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: macos dashmate build broken due to bad qemu install #1374

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Sep 7, 2023

Issue being fixed or feature implemented

CI was failing with

time="2023-09-05T08:06:14Z" level=warning msg="QEMU binary \"/Users/runner/.colima/_wrapper/4e1b408f843d1c63afbbdcf80c40e4c88d33509f/bin/qemu-system-x86_64\" is not properly signed with the \"com.apple.security.hypervisor\" entitlement" error="failed to run [codesign --verify /Users/runner/.colima/_wrapper/4e1b408f843d1c63afbbdcf80c40e4c88d33509f/bin/qemu-system-x86_64]: exit status 1 (out=\"/Users/runner/.colima/_wrapper/4e1b408f843d1c63afbbdcf80c40e4c88d33509f/bin/qemu-system-x86_64: code object is not signed at all\\nIn architecture: x86_64\\n\")"

What was done?

Implement workaround described in actions/runner-images#8104

How Has This Been Tested?

Tested fixing this bug only, there may be other bugs in the actual release which we can identify as new dev releases are done.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy changed the title fix(ci): macos dashmate build broken due to bad qemu install ci: macos dashmate build broken due to bad qemu install Sep 7, 2023
@strophy
Copy link
Collaborator Author

strophy commented Sep 8, 2023

Looks like this might not be necessary once we start getting runners with image version 20230901.1 so let's hold off merging this until we see if that fixes the problem instead.

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 52f2234 into v0.25-dev Sep 8, 2023
9 checks passed
@shumkov shumkov deleted the ci/fix-macos-dashmate-ci branch September 8, 2023 17:04
strophy added a commit that referenced this pull request Sep 12, 2023
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants