Skip to content

chore: enforce ban for re-propagation of stale QFCOMMITs #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 1 commit into from
Dec 23, 2025
Merged

chore: enforce ban for re-propagation of stale QFCOMMITs #7079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/llmq/blockprocessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ MessageProcessingResult CQuorumBlockProcessor::ProcessMessage(const CNode& peer,
if (pQuorumBaseBlockIndex->nHeight < (m_chainstate.m_chain.Height() - llmq_params_opt->dkgInterval)) {
LogPrint(BCLog::LLMQ, "CQuorumBlockProcessor::%s -- block %s is too old, peer=%d\n", __func__,
qc.quorumHash.ToString(), peer.GetId());
// TODO: enable punishment in some future version when all/most nodes are running with this fix
// ret.m_error = MisbehavingError{100};
if (peer.GetCommonVersion() >= QFCOMMIT_STALE_REPROP_BAN_VERSION) {
ret.m_error = MisbehavingError{100};
}
return ret;
}
if (HasMinedCommitment(type, qc.quorumHash)) {
Expand Down
7 changes: 4 additions & 3 deletions src/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
* network protocol versioning
*/


static const int PROTOCOL_VERSION = 70238;
static const int PROTOCOL_VERSION = 70239;

//! initial proto version, to be increased after version/verack negotiation
static const int INIT_PROTO_VERSION = 209;
Expand Down Expand Up @@ -52,13 +51,15 @@ static const int INCREASE_MAX_HEADERS2_VERSION = 70235;
//! Behavior of QRINFO is changed in this protocol version
static const int EFFICIENT_QRINFO_VERSION = 70236;


//! cycleHash in isdlock message switched to using quorum's base block in this version
static const int ISDLOCK_CYCLEHASH_UPDATE_VERSION = 70237;

//! Introduced new p2p message platform pose BAN
static const int PLATFORM_BAN_VERSION = 70238;

//! Ban of re-propagation of old QFCOMMIT enforcement
static const int QFCOMMIT_STALE_REPROP_BAN_VERSION = 70239;

// Make sure that none of the values above collide with `ADDRV2_FORMAT`.

#endif // BITCOIN_VERSION_H
Loading