Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Sep 29, 2025

Issue being fixed or feature implemented

d496df0 (#6829) changed SendCoinsEntry class from QStackedWidget to QWidget but we forgot to update css accordingly so GUI is a bit broken now.

Screenshot 2025-09-29 at 19 06 30

What was done?

Adjust css to match cpp

How Has This Been Tested?

Compile and check GUI, should look the same way it did before d496df0

Screenshot 2025-09-29 at 19 07 25

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 23 milestone Sep 29, 2025
@github-actions
Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

The CSS in src/qt/res/css/general.css updates multiple selectors within the SendCoinsEntry section, changing the parent selector from QStackedWidget#SendCoinsEntry to QWidget#SendCoinsEntry. Affected rules cover labels (including amountLabel), inputs (payTo, addAsLabel), tool buttons (general settings, addressBookButton, pasteButton, deleteButton), and related frames and labels. No new rules or properties were introduced; only the selector scope was modified for existing style rules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows conventional commit style by indicating a fix in the QT component and clearly specifies that the CSS adjustments apply to the SendCoinsEntry widget, which aligns directly with the changes in the pull request. It is concise, descriptive, and enables reviewers to understand the primary change at a glance. Therefore, it meets the criteria for clarity and relevance.
Description Check ✅ Passed The description clearly explains the underlying issue—updating the SendCoinsEntry class from QStackedWidget to QWidget without corresponding CSS changes—and details how the PR restores the GUI’s appearance. It references the original commit, outlines the changes made, describes testing steps, and includes before-and-after screenshots, all of which directly pertain to the changeset. This satisfies the lenient requirement that the description remain on-topic and related to the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/qt/res/css/general.css (1)

1730-1761: Approve CSS update for SendCoinsEntry
All QStackedWidget selectors removed and objectName “SendCoinsEntry” confirmed across code/UI; styles now correctly target QWidget#SendCoinsEntry. Optional: swap to “#SendCoinsEntry …” selectors to future-proof against base-class changes.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cae0bff and 9820d50.

📒 Files selected for processing (1)
  • src/qt/res/css/general.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: linux64_nowallet-build / Build source
  • GitHub Check: linux64_tsan-build / Build source
  • GitHub Check: win64-build / Build source
  • GitHub Check: arm-linux-build / Build source
  • GitHub Check: linux64_fuzz-build / Build source
  • GitHub Check: linux64_sqlite-build / Build source
  • GitHub Check: linux64-build / Build source
  • GitHub Check: linux64_ubsan-build / Build source
  • GitHub Check: x86_64-apple-darwin / Build depends
  • GitHub Check: Lint / Run linters

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


ACK 9820d50

Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 9820d50

@PastaPastaPasta PastaPastaPasta merged commit 8f4c8b9 into dashpay:develop Sep 30, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants