-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(qt): adjust css for SendCoinsEntry #6861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
WalkthroughThe CSS in src/qt/res/css/general.css updates multiple selectors within the SendCoinsEntry section, changing the parent selector from QStackedWidget#SendCoinsEntry to QWidget#SendCoinsEntry. Affected rules cover labels (including amountLabel), inputs (payTo, addAsLabel), tool buttons (general settings, addressBookButton, pasteButton, deleteButton), and related frames and labels. No new rules or properties were introduced; only the selector scope was modified for existing style rules. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/qt/res/css/general.css (1)
1730-1761: Approve CSS update for SendCoinsEntry
All QStackedWidget selectors removed and objectName “SendCoinsEntry” confirmed across code/UI; styles now correctly target QWidget#SendCoinsEntry. Optional: swap to “#SendCoinsEntry …” selectors to future-proof against base-class changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/qt/res/css/general.css(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: linux64_nowallet-build / Build source
- GitHub Check: linux64_tsan-build / Build source
- GitHub Check: win64-build / Build source
- GitHub Check: arm-linux-build / Build source
- GitHub Check: linux64_fuzz-build / Build source
- GitHub Check: linux64_sqlite-build / Build source
- GitHub Check: linux64-build / Build source
- GitHub Check: linux64_ubsan-build / Build source
- GitHub Check: x86_64-apple-darwin / Build depends
- GitHub Check: Lint / Run linters
kwvg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
knst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 9820d50

Issue being fixed or feature implemented
d496df0 (#6829) changed
SendCoinsEntryclass fromQStackedWidgettoQWidgetbut we forgot to updatecssaccordingly so GUI is a bit broken now.What was done?
Adjust css to match cpp
How Has This Been Tested?
Compile and check GUI, should look the same way it did before d496df0
Breaking Changes
n/a
Checklist: