Skip to content

fix: Reset all collections before reading in CDeterministicMNListDiff::Unserialize() #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

fix: Reset all collections before reading in CDeterministicMNListDiff::Unserialize() #6814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/evo/deterministicmns.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,8 @@ class CDeterministicMNListDiff
template <typename Stream>
void Unserialize(Stream& s)
{
// Reset all collections before reading
addedMNs.clear();
Copy link
Collaborator

@kwvg kwvg Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could be in a Clear() function like CDeterministicMNList (source) but non-blocker

updatedMNs.clear();
removedMns.clear();

Expand Down
Loading