refactor: various trivial fixes and dead code removals

[knst]

What was done?

See each commit

How Has This Been Tested?

Run unit / functional tests

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[coderabbitai]

Walkthrough

The changes consist of modifications to Git ignore configuration, consensus parameter adjustments, validation logic alterations, and wallet functionality updates. In the .gitignore file, a rule has been added to ignore config.status.old. In the chain parameters code, the BIP16Height variable has been removed from several network configurations as well as from the consensus parameters struct, indicating that the block height check for BIP16 is no longer used. The validation code now unconditionally sets the SCRIPT_VERIFY_P2SH flag on Dash chains rather than basing it on block height. Additionally, the wallet implementation has been revised by removing the unique pointer to the CoinJoin client from the WalletImpl class.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 794d346 and e8de32c.

📒 Files selected for processing (5)

• .gitignore (1 hunks)
• src/chainparams.cpp (0 hunks)
• src/consensus/params.h (0 hunks)
• src/validation.cpp (1 hunks)
• src/wallet/interfaces.cpp (0 hunks)

💤 Files with no reviewable changes (3)

• src/consensus/params.h
• src/chainparams.cpp
• src/wallet/interfaces.cpp

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_tsan-build / Build source
• GitHub Check: linux64_multiprocess-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: win64-build / Build source

🔇 Additional comments (2)

.gitignore (1)

42-42: Addition to ignore config.status.old:
This entry correctly ignores files generated during the configuration process (specifically config.status.old), preventing them from being accidentally committed. The change is appropriate and aligns with common practice for build artifacts.

src/validation.cpp (1)

2082-2084: Code simplification for BIP16 enforcement

The change correctly implements the unconditional enforcement of P2SH (BIP16) on Dash chains by removing the check against BIP16Height. This aligns with the PR's objective of removing dead code, as P2SH is meant to be permanently active on Dash chains.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[UdjinM6]

utACK e8de32c

[kwvg]

utACK e8de32c

[PastaPastaPasta]

utACK e8de32c