feat: dynamically register MN in functional tests without IS #6430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace wait-IS to bump time in test_framework
5 tasks
UdjinM6
approved these changes
Nov 26, 2024
PastaPastaPasta
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
utACK 37fbdee
Although I would say I'd prefer this to be scope "test" or something similar, as it's hard to call these changes a feat
knst
added a commit
to knst/dash
that referenced
this pull request
Aug 22, 2025
…p IS sport - no more need since dashpay#6430
knst
added a commit
to knst/dash
that referenced
this pull request
Aug 28, 2025
…pay#6430 Reduced amount of mn from 4 to just 3 as no needs for rotation quorum anymore Removed IS spork changes
knst
added a commit
to knst/dash
that referenced
this pull request
Aug 29, 2025
…pay#6430 Reduced amount of mn from 4 to just 3 as no needs for rotation quorum anymore Removed IS spork changes
knst
added a commit
to knst/dash
that referenced
this pull request
Aug 29, 2025
…pay#6430 Reduced amount of mn from 4 to just 3 as no needs for rotation quorum anymore Removed IS spork changes
Open
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has important fixes to implement "single-node quorum" feature.
Issue being fixed or feature implemented
Without IS-quorum you can not dynamically add a new MN or Evo node.
For evo nodes adding it dynamically is the only way.
What was done?
Fixed a function that dynamically adds a masternode without Instant Send quorums; use it in a functional test feature_asset_locks.py
As side effect it improves performance of functional tests which do not wait more IS lock significantly; for feature_asset_locks.py it gave ~20 seconds per run.
How Has This Been Tested?
See updates in
feature_asset_locks.py,feature_llmq_evo.py,feature_dip3_v19.pyBreaking Changes
N/A
Checklist: