fix: do not use extra_args for enforced DashTestFramework arguments #6283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
knst
force-pushed
the
fix-reuse-extra-args
branch
from
8a42cde to
8b3c83e
Compare
UdjinM6
requested changes
Sep 27, 2024
| self.extra_args[0] += ["-sporkkey=cP4EKFyJsHT39LDqgdcB43Y3YXjNyjb5Fuas1GQSeAtjnZWmZEQK"] | ||
| for i in range(0, num_nodes): | ||
| self.extra_args[i].append("-dip3params=2:2") | ||
| self.extra_args_from_options += ["-sporkkey=cP4EKFyJsHT39LDqgdcB43Y3YXjNyjb5Fuas1GQSeAtjnZWmZEQK", "-dip3params=2:2"] |
Collaborator
Author
There was a problem hiding this comment.
Why exactly sporkkey can't be specified for all nodes? It's out of scope for all tests except "feature_sporks.py" to care about sporks functionally
…=1 is default option
…nt for dashd restart Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>
knst
force-pushed
the
fix-reuse-extra-args
branch
from
8b3c83e to
6d4a782
Compare
UdjinM6
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
DashTestFramework requires 2 arguments for dashd which are lost every dashd restart:
sporkkeyanddip3params.Without this PR you need to pass this arguments manually every time when you restart dashd in functional tests.
What was done?
Make dash specific args
sporkkeyanddip3paramsresilient for dashd restartIt makes workarounds such as these no more needed:
Also there's some cleanup for
wallet_mnemonicbits.pyto removeusehd=1which is not required, and it has been discovered during revising all node's restarts related code.How Has This Been Tested?
Removed workaround from
rpc_net.pyand run functional testsBreaking Changes
N/A
Checklist: