Rethinking and cleaning up DS mixing / fixing mixing progress calculation #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STATIC=1 not cleanly implemented
Revert 25a07f1 -- makefile.unix
src/makefile.unix
Outdated
|
To be resubmitted for v0.11.0.x, will close |
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
QT - update locales from transifex
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 19, 2022
…d enum 0e5dedb qt/wallettests: sort includes (William Casarin) 0554251 qt: Skip displayUnitChanged signal if unit is not actually changed (Hennadii Stepanov) ffbc2fe qt, refactor: Remove default cases for scoped enum (Hennadii Stepanov) 152d5ba qt, refactor: Remove BitcoinUnits::valid function (Hennadii Stepanov) aa23960 qt, refactor: Make BitcoinUnits::Unit a scoped enum (Hennadii Stepanov) 75832fd qt: Use QVariant instead of int for BitcoinUnit in QSettings (Hennadii Stepanov) Pull request description: This is a rebased version of dashpay#60 Since Qt 5.5 there are [means](https://doc.qt.io/qt-5/qobject.html#Q_ENUM) to register an enum type with the meta-object system (such enum still lacks an ability to interact with [QSettings::setValue()](https://doc.qt.io/qt-5/qsettings.html#setValue) and [QSettings::value()](https://doc.qt.io/qt-5/qsettings.html#value) without defined stream operators). In order to reduce global namespace polluting and to force strong type checking, this PR makes BitcoinUnits::Unit a scoped enum (typedef BitcoinUnits::Unit BitcoinUnit;). No behavior change. ACKs for top commit: jonatack: ACK 0e5dedb, review and debug build of each commit after rebase on current master, lightly tested running the GUI, changing units a few times, and verifying persistence after restarting promag: Code review ACK 0e5dedb Tree-SHA512: 39ec0d7e4f0b9b25be287888121a8db6b282339674e37ec3a3554da63a9e22d6fe079e8310ca289b2a0356a19b3c7e55afa17d09dd34e0f222177f603bb053a3
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
* Add python bindings for threshold signatures * Attempt to fix CI build
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 2, 2023
22b066020c build: match detection of Win32 libraries with mimalloc (dashpay#60) 03268b3a02 Merge pull request dashpay#59 from kittywhiskers/repair_subtree 3d2e7a183e depends: commit microsoft/mimalloc@91ba1f37 to source tree as 44314dd9 7a4d1a01fa depends: remove mangled 'depends/mimalloc' subdirectory 44314dd972 Squashed 'depends/mimalloc/' content from commit 91ba1f37 8383f08 dashbls: replace flaky minialloc with microsoft/mimalloc@91ba1f37, add as vendored dependency (dashpay#55) 85b7e61 fix: Should not check validity for legacy G1 and G2 in FromBytes (dashpay#58) 7457939 chore/fix: bump Catch2 to v2.13.10 (dashpay#57) git-subtree-dir: src/dashbls git-subtree-split: 22b066020c14bd162022c73f90fc7c940f4acdda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to rethink and cleanup how DS mixing works.
Also implemented another approach to calculate mixing progress.
Still need testing/tweaking with different amounts etc.