Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Apr 21, 2024

Issue being fixed or feature implemented

Our CI nodes on Amazon have issues running tests using ipv6.

What was done?

Pretend we don't have ipv6 when we run tests for now

How Has This Been Tested?

See CI results for this PR.

Breaking Changes

n/a but we'll have ipv6 not being tested for some time.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 changed the title tests: disable ipv6 tests for now test: disable ipv6 tests for now Apr 21, 2024
@UdjinM6 UdjinM6 force-pushed the disable_ipv6_tests branch from 6516cae to 10a006e Compare April 21, 2024 12:12
@UdjinM6 UdjinM6 added this to the 21 milestone Apr 22, 2024
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 10a006e

@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review April 23, 2024 14:29
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 10a006e

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 10a006e

@knst
Copy link
Collaborator

knst commented Jun 6, 2024

let's backport this changes to master? @UdjinM6 @PastaPastaPasta

Currently our CI looks like "broken"
image

knst added a commit to knst/dash that referenced this pull request Jul 28, 2025
This reverts commit 0bb188a, reversing
changes made to 45bdfa5.
knst added a commit to knst/dash that referenced this pull request Dec 23, 2025
This reverts commit 0bb188a, reversing
changes made to 45bdfa5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants