chore: blockchain updates for v20.1: chainparams, seeds #5914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
solved, see commit messages |
knst
force-pushed
the
v20.1-blockchain
branch
from
9c6594f to
4af12d9
Compare
UdjinM6
requested changes
Feb 29, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks mostly ok, one issue, see below. Also, what about testnet?
Collaborator
Author
Hmm, mr_rr is not activated yet on testnet so probably no reorganize would happen. I'll update then. |
knst
force-pushed
the
v20.1-blockchain
branch
from
4af12d9 to
1d685f7
Compare
knst
force-pushed
the
v20.1-blockchain
branch
from
1d685f7 to
8daf938
Compare
UdjinM6
approved these changes
Mar 1, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
utACK (verified blockhashes etc. in chainparams)
PastaPastaPasta
force-pushed
the
v20.1-blockchain
branch
from
8daf938 to
222e413
Compare
PastaPastaPasta
approved these changes
Mar 4, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK; rebased to change commit names a bit
Don't forget to specify onion_seeds.txt: ``` cd contrib/seeds dash-cli protx list valid 1 > protx.txt ./makeseeds.py protx.txt onion_seeds.txt > nodes_main.txt ./generate-seeds.py . > ../../src/chainparamsseeds.h ```
```
$ ./makeseeds.py protx.txt > nodes_main.txt
Traceback (most recent call last):
File "DASH/contrib/seeds/./makeseeds.py", line 183, in <module>
main()
File "DASH/contrib/seeds/./makeseeds.py", line 167, in main
for onion in onions:
^^^^^^
UnboundLocalError: cannot access local variable 'onions' where it is not associated with a value
```
PastaPastaPasta
force-pushed
the
v20.1-blockchain
branch
from
222e413 to
97a331c
Compare
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Part of release process to update seeds and chainparams: https://github.com/dashpay/dash/blob/develop/doc/release-process.md
Breaking Changes
N/A
Checklist: