Skip to content

Conversation

@knst
Copy link
Collaborator

@knst knst commented Jul 17, 2023

Issue being fixed or feature implemented

Here's TODO that seems out-dated

/// TODO: all 4 functions do not belong here really, they should be refactored/moved somewhere (main.cpp ?)

This changes are extracted from this PR: #5342

What was done?

This changes hides some methods from global namespace (making local static function), hiding other functions to the namespace

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20 milestone Jul 17, 2023
@knst knst requested review from PastaPastaPasta and UdjinM6 and removed request for PastaPastaPasta July 17, 2023 15:45
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@knst
Copy link
Collaborator Author

knst commented Jul 17, 2023

For easier code review you may find git show --color-moved=zebra 21adeea4b85fa47ce728f850be1ad7725181b1e8 useful so far as it shows moved code by different color.

Copy link

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit be1ca25 into dashpay:develop Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants