Skip to content

test: Fix tsan build failure #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 2 commits into from
May 17, 2023
Merged

test: Fix tsan build failure #5376

UdjinM6 merged 2 commits into from
May 17, 2023

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented May 17, 2023

Issue being fixed or feature implemented

Should fix tasn build failures observed in #5365

What was done?

Complete 19775 backport + fix Dash-specific parts to follow the same logic ("avoid calling SelectParams twice")

How Has This Been Tested?

https://gitlab.com/UdjinM6/dash/-/jobs/4297285595 + ran test_dash built with --with-sanitizers=thread on linux vps

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone May 17, 2023
PastaPastaPasta
PastaPastaPasta approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@UdjinM6 UdjinM6 requested review from kwvg and ogabrielides May 17, 2023 17:27
kwvg
kwvg approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ogabrielides
ogabrielides approved these changes May 17, 2023
View reviewed changes
Copy link

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UdjinM6 UdjinM6 merged commit 8e148c8 into dashpay:develop May 17, 2023
@UdjinM6 UdjinM6 deleted the fix_tsan branch May 17, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@kwvg kwvg kwvg approved these changes

+1 more reviewer

@ogabrielides ogabrielides ogabrielides approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6 @ogabrielides @PastaPastaPasta @kwvg