Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Apr 27, 2023

Issue being fixed or feature implemented

Screenshot 2023-04-26 at 22 40 54

after:

Screenshot 2023-04-26 at 22 41 30

using TS_WARNING in sendcoinsdialog:
Screenshot 2023-05-01 at 20 38 12
Screenshot 2023-05-01 at 21 38 20

  • there are ugly borders in statusbar when running on windows, fix them via css

before:
dc_before

after:
dc_after

What was done?

How Has This Been Tested?

run dash-qt --regtest --nowallet --resetguisettings

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Apr 27, 2023
knst
knst previously approved these changes Apr 29, 2023
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS_WARNING and TS_ERROR looks so much better.

tACK

may be also update TS_ERROR to TS_WARNING here?

src/qt/sendcoinsdialog.cpp:
            questionString.append("<span style='" + GUIUtil::getThemedStyleQString(GUIUtil::ThemedStyle::TS_ERROR) + "'>");
            questionString.append(tr("Warning: Using %1 with %2 or more inputs can harm your privacy and is not recommended").arg(strCoinJoinName).arg(10));
...
src/qt/sendcoinsdialog.cpp:
        questionString.append("<span style='" + GUIUtil::getThemedStyleQString(GUIUtil::ThemedStyle::TS_ERROR) + "'>");
        questionString.append(tr("<b>(%1 of %2 entries displayed)</b>").arg(displayedEntries).arg(messageEntries));

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 4cd7e9a into dashpay:develop May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants