fix: making builds of guix to produce same output whatever git config #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UdjinM6
approved these changes
Feb 24, 2023
PastaPastaPasta
approved these changes
Feb 25, 2023
ogabrielides
pushed a commit
to ogabrielides/dash
that referenced
this pull request
Feb 28, 2023
…dashpay#5222) Builds are different, because git command output are different: ## Issue being fixed or feature implemented in pr dashpay#5194 different OS produced different hashes of binary. That's due to different behaviour of this command: ```sh $ git rev-parse --short HEAD b3f242d - on my localhost Kubuntu 22.10 b3f242d - inside pastapastapasta's docker ``` ## What was done? This fix forces to git print always 12 character ## How Has This Been Tested? Run in different environment ## Breaking Changes No breaking changes ## Checklist: - [x] I have performed a self-review of my own code - [x] I have assigned this pull request to a milestone
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are different, because git command output are different:
Issue being fixed or feature implemented
in pr #5194 different OS produced different hashes of binary.
That's due to different behaviour of this command:
$ git rev-parse --short HEAD b3f242da14 - on my localhost Kubuntu 22.10 b3f242da1 - inside pastapastapasta's dockerWhat was done?
This fix forces to git print always 12 character
How Has This Been Tested?
Run in different environment
Breaking Changes
No breaking changes
Checklist: