fix!: Return FinalCommitment in qrinfo (instead of simply quorumHash) #4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
May 27, 2022
PastaPastaPasta
approved these changes
May 28, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 29, 2022
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 16, 2023
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qrinfomessage must return lastFinalCommitmentinstead of simplyquorumHash.Clients need additional information (quorumPublicKey for instance) in order to verify locks.