Skip to content

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Feb 26, 2022

No description provided.

@github-actions
Copy link

This pull request has conflicts, please rebase.

@kwvg kwvg force-pushed the muhash branch 2 times, most recently from f559701 to 6504caf Compare April 24, 2022 11:23
@kwvg kwvg marked this pull request as ready for review April 24, 2022 11:23
@kwvg kwvg requested review from UdjinM6 and PastaPastaPasta April 24, 2022 11:23
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@UdjinM6 UdjinM6 added this to the 19 milestone Apr 26, 2022
Comment on lines 1270 to 1271
{RPCResult::Type::STR_HEX, "hash_serialized_2", "The serialized hash (only present if 'hash_serialized_2' hash_type is chosen)"},
{RPCResult::Type::STR_HEX, "muhash", "The serialized hash (only present if 'muhash' hash_type is chosen)"},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19145: note: missing optional (should either wait for #4734 or update this part in #4734 on rebase cc @Munkybooty)

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@PastaPastaPasta PastaPastaPasta merged commit 2197786 into dashpay:develop Apr 28, 2022
@PastaPastaPasta PastaPastaPasta added the Needs Release Notes This PR includes breaking changes for which release notes have not yet been merged. label Apr 28, 2022
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Apr 28, 2022
@kwvg kwvg deleted the muhash branch July 18, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Release Notes This PR includes breaking changes for which release notes have not yet been merged. RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants