build: gitian, linting and macOS-specific QoL improvements (part 2) #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2021
|
This pull request has conflicts, please rebase. |
kwvg
force-pushed
the
darwinqol_2
branch
4 times, most recently
from
1af7c81 to
f0978c1
Compare
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
UdjinM6
requested changes
Sep 3, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Let's drop 25a4330 and patch 19240 instead UdjinM6@30ad681 (also, why it's "force-merge"?)
PastaPastaPasta
requested changes
Sep 3, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
LGTM, one minor thing
… when cross-compiling
PastaPastaPasta
approved these changes
Sep 3, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shares history with #4255, merge #4255 first!
Part 1: #4255
Part 2: #4378 (this pull request)
Part 3: #4379