Merge bitcoin#14771: test: Add BOOST_REQUIRE to getters returning optional #4297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional fa21ca0 test: Add BOOST_REQUIRE to getters returning optional (MarcoFalke) Pull request description: Usually the returned value is already checked for equality, but for sanity we might as well require that the getter successfully returned.
Author
|
There's a second component of bitcoin#14771, which seems to be adding |
UdjinM6
requested changes
Jul 28, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
It looks like Dash is generally not adding
NODISCARDnor the[[nodiscard]]attribute.
Yeah, it's rare but we do have it in a few places e.g. https://github.com/dashpay/dash/blob/develop/src/evo/deterministicmns.h#L511. I think this part should be backported as well (NOTE: pls use [[nodiscard]] instead of NODISCARD).
5tefan
force-pushed
the
backports_018_2a97f192e
branch
from
7fc706e to
7dd526f
Compare
PastaPastaPasta
approved these changes
Jul 29, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 24, 2022
…ional (dashpay#4297) * Merge bitcoin#14771: test: Add BOOST_REQUIRE to getters returning optional fa21ca0 test: Add BOOST_REQUIRE to getters returning optional (MarcoFalke) Pull request description: Usually the returned value is already checked for equality, but for sanity we might as well require that the getter successfully returned. * Ports [[nodiscard]] portion of bitcoin#14771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges bitcoin#14771: test: Add BOOST_REQUIRE to getters returning optional
fa21ca0 test: Add BOOST_REQUIRE to getters returning optional
(MarcoFalke)
Pull request description:
Usually the returned value is already checked for equality, but for
sanity we might as well require that the getter successfully returned.