Merge bitcoin#14636: Avoid using numeric_limits for sequence numbers and lock times #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
changed the title
Member
|
The diff looks good. However, please base all work off of the develop branch. I have changed the 'base branch' in github, however you PR now has conflicts that need to be resolved by rebasing on develop. Let me know if you need help on doing that. Also I changed the title to be more inline with expected. Overall looks good! |
5tefan
force-pushed
the
backports_018_e8d490f27
branch
from
fe1aa6f to
d1ea7d9
Compare
Merges bitcoin#14636: Avoid using numeric_limits for sequence numbers and lock times. 5352030 Avoid using numeric_limits for sequence numbers and lock times (Russell Yanofsky) bafb921 Remove duplicated code (Hennadii Stepanov) e4dc39b Replace platform dependent type with proper const (Hennadii Stepanov) Pull request description: Switches to named constants, because numeric_limits calls can be harder to read and less portable. Change was suggested by jamesob in bitcoin#10973 (comment) There are no changes in behavior except on some platforms we don't support (ILP64, IP16L32, I16LP32), where `SignalsOptInRBF` and `MutateTxAddInput` functions would now work correctly.
5tefan
force-pushed
the
backports_018_e8d490f27
branch
from
d1ea7d9 to
c64f797
Compare
Author
|
Ahh, I see. Thanks! Rebase done and conflicts resolved. |
PastaPastaPasta
approved these changes
Jul 28, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 9, 2023
…and lock times (dashpay#4296) Merges bitcoin#14636: Avoid using numeric_limits for sequence numbers and lock times. 5352030 Avoid using numeric_limits for sequence numbers and lock times (Russell Yanofsky) bafb921 Remove duplicated code (Hennadii Stepanov) e4dc39b Replace platform dependent type with proper const (Hennadii Stepanov) Pull request description: Switches to named constants, because numeric_limits calls can be harder to read and less portable. Change was suggested by jamesob in bitcoin#10973 (comment) There are no changes in behavior except on some platforms we don't support (ILP64, IP16L32, I16LP32), where `SignalsOptInRBF` and `MutateTxAddInput` functions would now work correctly.
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
…and lock times (dashpay#4296) Merges bitcoin#14636: Avoid using numeric_limits for sequence numbers and lock times. 5352030 Avoid using numeric_limits for sequence numbers and lock times (Russell Yanofsky) bafb921 Remove duplicated code (Hennadii Stepanov) e4dc39b Replace platform dependent type with proper const (Hennadii Stepanov) Pull request description: Switches to named constants, because numeric_limits calls can be harder to read and less portable. Change was suggested by jamesob in bitcoin#10973 (comment) There are no changes in behavior except on some platforms we don't support (ILP64, IP16L32, I16LP32), where `SignalsOptInRBF` and `MutateTxAddInput` functions would now work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges bitcoin#14636: Avoid using numeric_limits for sequence
numbers and lock times.
5352030 Avoid using numeric_limits for sequence numbers and lock
times (Russell Yanofsky)
bafb921 Remove duplicated code (Hennadii Stepanov)
e4dc39b Replace platform dependent type with proper const
(Hennadii Stepanov)
Pull request description:
Switches to named constants, because numeric_limits calls can be
harder to read and less portable.
Change was suggested by jamesob in
bitcoin#10973 (comment)
There are no changes in behavior except on some platforms we don't
support (ILP64, IP16L32, I16LP32), where
SignalsOptInRBFandMutateTxAddInputfunctions would now work correctly.