Skip to content

Drop excessive cs_main locks in governance sync code #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 1 commit into from
Jul 19, 2021
Merged

Drop excessive cs_main locks in governance sync code #4280

UdjinM6 merged 1 commit into from
Jul 19, 2021

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jul 19, 2021 •
edited
Loading

Not sure why we were holding them there in the first place. Also fixes a deadlock:

POTENTIAL DEADLOCK DETECTED
Previous lock order was:
 (1) cs masternode/masternode-sync.cpp:151 (in thread )
 (2) cs_main governance/governance.cpp:977 (in thread )
Current lock order is:
 (2) cs_main init.cpp:2071 (in thread )
 (2) cs_main validation.cpp:4510 (in thread )
 (1) cs ./masternode/masternode-sync.h:56 (in thread )

@UdjinM6 UdjinM6 added this to the 18 milestone Jul 19, 2021
PastaPastaPasta
PastaPastaPasta approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@UdjinM6 UdjinM6 merged commit b0a1f2b into dashpay:develop Jul 19, 2021
@UdjinM6 UdjinM6 mentioned this pull request Jul 27, 2021
Merged
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 11, 2022
@UdjinM6 @gades
Drop excessive cs_main locks in governance sync code (dashpay#4280)
e2900a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

2 participants

@UdjinM6 @PastaPastaPasta