Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add uacomment in P2PConnection and use it to create (correct network specific) strSubVer #3969

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 25, 2021

Inspired by #3953 :)

@UdjinM6 UdjinM6 added this to the 17 milestone Jan 25, 2021
@UdjinM6 UdjinM6 marked this pull request as ready for review January 25, 2021 18:32
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM

Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@xdustinface xdustinface merged commit 783f07e into dashpay:develop Jan 25, 2021
@UdjinM6 UdjinM6 deleted the uacom_p2pcon branch July 1, 2021 21:56
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants