Use build badges provided by Gitlab #3915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
ACK
Can also preview directly in PR: https://github.com/dashpay/dash/pull/3915/files?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
May 9, 2025
…r` and `develop` b8236c8 docs: add build badge from GitHub Actions runs on `master` and `develop` (Kittywhiskers Van Gogh) Pull request description: ## Motivation Since [dash#6604](#6604), we haven't seen GitHub Actions runners experience sporadic failures that aren't the result of test failures. In comparison, GitLab CI has been showing greater instability with its runners ([build](https://gitlab.com/dashpay/dash/-/jobs/9960288430), [build](https://gitlab.com/dashpay/dash/-/jobs/9922122668)). As GitHub Actions runners are now at coverage parity with GitLab CI, this pull request adds status badges for it in the same vein as [dash#3915](#3915). ## How Has This Been Tested?  ## Checklist - [x] I have performed a self-review of my own code **(note: N/A)** - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: LGTM, utACK b8236c8 Tree-SHA512: 705f1be11274689c590029c0695737f2da2e47f2e8591b2a5113de91a2473eef6a24195d5d1918f5dcdaad63d364ac75867ddc3bf2b914d57fba22de1fcad4d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
Live: https://github.com/UdjinM6/dash/tree/fixbadges