Fix CDKGSessionHandler thread names #3896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers seems to have an issue with this implicit conversion producing garbage instead of numbers.
xdustinface
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
utACK because it's nothing bad but i can't confirm this solves anything 😄 Kind of hard to imagine this leads to garbage with the format specifier %d 🤔 But i guess this fix has been confirmed on the setup where the "garbage printing" occurred? Just as sidenote, getting garbage as thread names is also what we got before #3609 where the string was deallocated already when printed.
|
tested. it fixes issue with thread names. |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 13, 2022
Some compilers seems to have an issue with this implicit conversion producing garbage instead of numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers seems to have an issue with this implicit conversion producing garbage instead of numbers.
We had an explicit conversion here initially but it was dropped here accidentally.
(thanks to @MrDefacto for reporting an issue)