Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Sep 19, 2020

This kind of situations are unlikely to happen in normal conditions but can be unintentionally caused by advanced users/3-rd party developers messing with datadir. Currently the node would simply crash, with this PR it follows the usual chain corruption flow.

@UdjinM6 UdjinM6 added this to the 17 milestone Sep 19, 2020
@PastaPastaPasta
Copy link
Member

concept ACK so far, light utACK, will test later

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 29c7c6a into dashpay:develop Sep 25, 2020
@UdjinM6 UdjinM6 deleted the fixdbupgrade branch November 26, 2020 13:26
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jul 1, 2021
…ashpay#3722)

* Handle situations when we have evodb records but no blocks anymore

* Use IsEmpty

* Apply suggestions from code review

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 11, 2022
…ashpay#3722)

* Handle situations when we have evodb records but no blocks anymore

* Use IsEmpty

* Apply suggestions from code review

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants