-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt: Finetune Options Dialog #3709
Conversation
One more tweak, thanks @xdustinface for the idea 👍
(I disabled some code to make screenshots, there were no Window tab and there are no new options on Main tab on mac after the change) |
Hmm im not really a fan of giving the dialog such a huge |
@xdustinface how about 6ce7634? EDIT: re "empty" checkboxes: I'd try to avoid hacks like that tbh |
Yeah also not the biggest fan but if they don't give the checkbox Anyway, im good with 6ce7634 if you don't want to spend more time on this 👍 |
One more for here: Thoughts about 5d3b1e2 i.e. dropping the surrounding "Expert" |
Agree, this looks better 👍 Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, looks good, however, please update the PR description to match new changes
* Fix proxy port ui elements * Fix fake net checkboxes * Fix active options label by enabling text wrapping * Fix options dialog resizing when font size is changed * Move "Window" tab options into "Main" tab, drop "Window" tab * Shrink min sizes a bit * qt: Drop the surrounding QGroupBox in Options -> Wallet Co-authored-by: xdustinface <xdustinfacex@gmail.com>
* Fix proxy port ui elements * Fix fake net checkboxes * Fix active options label by enabling text wrapping * Fix options dialog resizing when font size is changed * Move "Window" tab options into "Main" tab, drop "Window" tab * Shrink min sizes a bit * qt: Drop the surrounding QGroupBox in Options -> Wallet Co-authored-by: xdustinface <xdustinfacex@gmail.com>
Note: you can't see it on screenshots here but the long translation of the
connectSocksTor
checkbox text (e.g. inru
) also caused dialog resizing for bigger fonts (in case you are wondering why this one was tweaked too :) )EDIT:
With this PR if a translation of the
connectSocksTor
checkbox is too long it's simply clippedbut you can see the whole text if you resize the dialog manually
Basically, it's a sign that translation should be shortened somehow but it at least doesn't cause resizing issues like it does currently.
EDIT2: This PR also removes Window tab and moves all its options into Main tab, see #3709 (comment) for screenshots.