Skip to content

Conversation

@xdustinface
Copy link

@xdustinface xdustinface commented Jun 26, 2020

This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3570, its successor is #3572. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.

-> Walk through 0.15
-> Walk through Redesign

I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.

About this PR

This PR disables scrollbars.css loading and adds a "windows,other" section in general.css, dark.css and light.css where it adds customizations for scrollbars in each theme.

@xdustinface xdustinface force-pushed the pr-ui-18-scrollbar-css branch 2 times, most recently from d41a690 to df2b987 Compare June 27, 2020 20:24
@xdustinface xdustinface marked this pull request as draft June 30, 2020 20:25
This disabled scrollbars.css loading and adds a "windows,other" section in general.css, dark.css and light.css where it adds customizations for scrollbars in each theme.
@xdustinface xdustinface force-pushed the pr-ui-18-scrollbar-css branch from df2b987 to 44de8a9 Compare July 21, 2020 00:19
@xdustinface xdustinface marked this pull request as ready for review July 21, 2020 00:19
@xdustinface
Copy link
Author

Ready for review!

@UdjinM6 UdjinM6 added this to the 17 milestone Jul 21, 2020
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested on mac and windows

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit b3be0ba into dashpay:develop Jul 26, 2020
xdustinface added a commit to xdustinface/dash that referenced this pull request Jul 28, 2020
* qt: Add platform specific css style for scrollbars

This disabled scrollbars.css loading and adds a "windows,other" section in general.css, dark.css and light.css where it adds customizations for scrollbars in each theme.

* qt: Remove scrollbar.css and all its remaining mentions

* qt: Run update-css-files.py
xdustinface added a commit to xdustinface/dash that referenced this pull request Sep 1, 2020
* qt: Add platform specific css style for scrollbars

This disabled scrollbars.css loading and adds a "windows,other" section in general.css, dark.css and light.css where it adds customizations for scrollbars in each theme.

* qt: Remove scrollbar.css and all its remaining mentions

* qt: Run update-css-files.py
xdustinface added a commit to xdustinface/dash that referenced this pull request Sep 1, 2020
* qt: Add platform specific css style for scrollbars

This disabled scrollbars.css loading and adds a "windows,other" section in general.css, dark.css and light.css where it adds customizations for scrollbars in each theme.

* qt: Remove scrollbar.css and all its remaining mentions

* qt: Run update-css-files.py
@UdjinM6 UdjinM6 modified the milestones: 17, 16 Sep 4, 2020
UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Apr 11, 2021
It was removed from the build via dashpay#3571 and is no longer used in any way
PastaPastaPasta pushed a commit that referenced this pull request Apr 11, 2021
It was removed from the build via #3571 and is no longer used in any way
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Apr 13, 2021
It was removed from the build via dashpay#3571 and is no longer used in any way
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 3, 2022
* qt: Add platform specific css style for scrollbars

This disabled scrollbars.css loading and adds a "windows,other" section in general.css, dark.css and light.css where it adds customizations for scrollbars in each theme.

* qt: Remove scrollbar.css and all its remaining mentions

* qt: Run update-css-files.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants