qt: Redesign BitcoinAmountField #3569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2020
xdustinface
force-pushed
the
pr-ui-16-bitcoinamountfield
branch
2 times, most recently
from
89296d4 to
7f18421
Compare
Make its data also accessible int, not only by QModelIndex.
- AmountSpinBox (QAbstractBox) is now called AmountLineEdit (QLineEdit) - Replaced the AmountSpinBox and the QValueComboBox with just an AmountLineEdit - Adjusted min-size hint calculation - Increased maximum width - Right-Align text - Removed obsolete code
Make sure it does not get stretched above the in AmountLineEdit::minimumSizeHint() calculated size.
Its fixed now with the change to a normal line edit.
xdustinface
force-pushed
the
pr-ui-16-bitcoinamountfield
branch
from
7f18421 to
4b174da
Compare
Author
|
Ready for review! |
PastaPastaPasta
approved these changes
Jul 18, 2020
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
light ACK. looks fine, seems to not break stuff
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Jul 28, 2020
* qt: Remove min-width of BitcoinAmountField in ReceiveCoinsDialog * qt: Add BitcoinUnits::data(const int &row, int role) Make its data also accessible int, not only by QModelIndex. * qt: Adjust BitcoinAmountField - AmountSpinBox (QAbstractBox) is now called AmountLineEdit (QLineEdit) - Replaced the AmountSpinBox and the QValueComboBox with just an AmountLineEdit - Adjusted min-size hint calculation - Increased maximum width - Right-Align text - Removed obsolete code * qt: Removed leftover from legacy BitcoinAmountField * qt: Move amount field into a Hlayout with a spacer (ReveiveCoinsDialog) Make sure it does not get stretched above the in AmountLineEdit::minimumSizeHint() calculated size. * qt: Removed obsolete workaround related to BitcoinAmountField Its fixed now with the change to a normal line edit.
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: Remove min-width of BitcoinAmountField in ReceiveCoinsDialog * qt: Add BitcoinUnits::data(const int &row, int role) Make its data also accessible int, not only by QModelIndex. * qt: Adjust BitcoinAmountField - AmountSpinBox (QAbstractBox) is now called AmountLineEdit (QLineEdit) - Replaced the AmountSpinBox and the QValueComboBox with just an AmountLineEdit - Adjusted min-size hint calculation - Increased maximum width - Right-Align text - Removed obsolete code * qt: Removed leftover from legacy BitcoinAmountField * qt: Move amount field into a Hlayout with a spacer (ReveiveCoinsDialog) Make sure it does not get stretched above the in AmountLineEdit::minimumSizeHint() calculated size. * qt: Removed obsolete workaround related to BitcoinAmountField Its fixed now with the change to a normal line edit.
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: Remove min-width of BitcoinAmountField in ReceiveCoinsDialog * qt: Add BitcoinUnits::data(const int &row, int role) Make its data also accessible int, not only by QModelIndex. * qt: Adjust BitcoinAmountField - AmountSpinBox (QAbstractBox) is now called AmountLineEdit (QLineEdit) - Replaced the AmountSpinBox and the QValueComboBox with just an AmountLineEdit - Adjusted min-size hint calculation - Increased maximum width - Right-Align text - Removed obsolete code * qt: Removed leftover from legacy BitcoinAmountField * qt: Move amount field into a Hlayout with a spacer (ReveiveCoinsDialog) Make sure it does not get stretched above the in AmountLineEdit::minimumSizeHint() calculated size. * qt: Removed obsolete workaround related to BitcoinAmountField Its fixed now with the change to a normal line edit.
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 10, 2022
* qt: Remove min-width of BitcoinAmountField in ReceiveCoinsDialog * qt: Add BitcoinUnits::data(const int &row, int role) Make its data also accessible int, not only by QModelIndex. * qt: Adjust BitcoinAmountField - AmountSpinBox (QAbstractBox) is now called AmountLineEdit (QLineEdit) - Replaced the AmountSpinBox and the QValueComboBox with just an AmountLineEdit - Adjusted min-size hint calculation - Increased maximum width - Right-Align text - Removed obsolete code * qt: Removed leftover from legacy BitcoinAmountField * qt: Move amount field into a Hlayout with a spacer (ReveiveCoinsDialog) Make sure it does not get stretched above the in AmountLineEdit::minimumSizeHint() calculated size. * qt: Removed obsolete workaround related to BitcoinAmountField Its fixed now with the change to a normal line edit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3568, its successor is #3570. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
This PR gives the BitcoinAmountField a redesign. It removes the spinbox and the unit selector. Result is just a line edit with the same validation and background functionality. Its still possible to change the input unit by changing the global unit selector to the desired unit.