Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Slightly adjust some README.md files #3175

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

PastaPastaPasta
Copy link
Member

No description provided.

Signed-off-by: Pasta <pasta@dashboost.org>
@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 24, 2019
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

utACK

@@ -1,13 +1,13 @@
Dash Core staging tree 0.14.1
===============================
=============================
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just add a # at the beginning of this header and remove the === entirely? It achieves the same effect in Markdown and doesn't require re-aligning the === underneath every time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like another pr to me :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# and ==== are used interchangeably in various other *.md files all over the repo. Should swap them all at once if we decide to do so imo, but I would rather just leave it as is tbh.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this is a nit, and swapping them all at once makes sense.


`master:` [![Build Status](https://travis-ci.org/dashpay/dash.svg?branch=master)](https://travis-ci.org/dashpay/dash) `develop:` [![Build Status](https://travis-ci.org/dashpay/dash.svg?branch=develop)](https://travis-ci.org/dashpay/dash/branches)

https://www.dash.org


What is Dash?
----------------
-------------
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, can use ## for the H2 header.

Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

(I also prefer # over ====, but it's a nit IMHO)

Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 3c21d25 into dashpay:develop Oct 29, 2019
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
Signed-off-by: Pasta <pasta@dashboost.org>
@PastaPastaPasta PastaPastaPasta deleted the update-readme branch April 16, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants