Keep the most recent gobject votes only #2815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarley
reviewed
Mar 29, 2019
UdjinM6
force-pushed
the
keepthemostrecentvoteonly
branch
from
b1f407f to
e1cfe98
Compare
codablock
previously approved these changes
Mar 30, 2019
We don't need to store full vote data for old votes - we never relay them to other nodes anyway. Still keep old hashes to avoid re-requesting data etc.
UdjinM6
force-pushed
the
keepthemostrecentvoteonly
branch
2 times, most recently
from
1a30eca to
c16d8e0
Compare
Also add comments
UdjinM6
force-pushed
the
keepthemostrecentvoteonly
branch
from
c16d8e0 to
a8e0d30
Compare
codablock
approved these changes
Apr 1, 2019
thephez
added a commit
to thephez/dash-docs
that referenced
this pull request
Apr 8, 2019
- Related to dashpay/dash#2815
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Apr 10, 2019
* RPC - Update masternode current and winner - Remove protocol, lastseen, activeseconds * RPC - Remove gobject getvotes - Related to dashpay/dash#2815 * RPC - Protx diff update - Add merkleRootQuorums field Related to dashpay/dash#2833 * RPC - listunspent update Related to dashpay/dash#2727 * RPC - protx update_registrar update - Rename votingKeyAddr to votingAddress Related to dashpay/dash#2747 * RPC - Add bls fromsecret Related to dashpay/dash#2841 * RPC - Start adding quorum RPCs * RPC - Add quorum info details Minor formatting updates * RPC - Add placeholders for remaining quorum sub-commands * RPC - Add quorum sign/hasrecsig/isconflicting details * RPC - Add note to regtest only quorum RPCs * RPC - Add more detail to quorum dkgstatus * Typo fix * Minor format and example updates * RPC - Add more quorum dkgstatus details - Field descriptions * RPC - Add quorum dkgstatus detail level 1 and 2 info * RPC - protx update - Remove support for "0" Related to dashpay/dash#2622
thephez
added a commit
to thephez/dash-docs
that referenced
this pull request
May 17, 2019
* RPC - Update masternode current and winner - Remove protocol, lastseen, activeseconds * RPC - Remove gobject getvotes - Related to dashpay/dash#2815 * RPC - Protx diff update - Add merkleRootQuorums field Related to dashpay/dash#2833 * RPC - listunspent update Related to dashpay/dash#2727 * RPC - protx update_registrar update - Rename votingKeyAddr to votingAddress Related to dashpay/dash#2747 * RPC - Add bls fromsecret Related to dashpay/dash#2841 * RPC - Start adding quorum RPCs * RPC - Add quorum info details Minor formatting updates * RPC - Add placeholders for remaining quorum sub-commands * RPC - Add quorum sign/hasrecsig/isconflicting details * RPC - Add note to regtest only quorum RPCs * RPC - Add more detail to quorum dkgstatus * Typo fix * Minor format and example updates * RPC - Add more quorum dkgstatus details - Field descriptions * RPC - Add quorum dkgstatus detail level 1 and 2 info * RPC - protx update - Remove support for "0" Related to dashpay/dash#2622
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
May 17, 2019
* RPC - Update masternode current and winner - Remove protocol, lastseen, activeseconds * RPC - Remove gobject getvotes - Related to dashpay/dash#2815 * RPC - Protx diff update - Add merkleRootQuorums field Related to dashpay/dash#2833 * RPC - listunspent update Related to dashpay/dash#2727 * RPC - protx update_registrar update - Rename votingKeyAddr to votingAddress Related to dashpay/dash#2747 * RPC - Add bls fromsecret Related to dashpay/dash#2841 * RPC - Start adding quorum RPCs * RPC - Add quorum info details Minor formatting updates * RPC - Add placeholders for remaining quorum sub-commands * RPC - Add quorum sign/hasrecsig/isconflicting details * RPC - Add note to regtest only quorum RPCs * RPC - Add more detail to quorum dkgstatus * Typo fix * Minor format and example updates * RPC - Add more quorum dkgstatus details - Field descriptions * RPC - Add quorum dkgstatus detail level 1 and 2 info * RPC - protx update - Remove support for "0" Related to dashpay/dash#2622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drops
gobject getvotesrpc.