Skip to content

Implement persistence for LLMQ based InstantSend #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codablock merged 12 commits into from
Mar 12, 2019
Merged

Implement persistence for LLMQ based InstantSend #2756

codablock merged 12 commits into from
Mar 12, 2019

Conversation

@codablock
Copy link

@codablock codablock commented Mar 11, 2019

This PR makes finished/final InstantSend locks persistent, which means they are still present after restart of the node.

It also introduces unordered_lru_cache for CInstantSendDb and also switches CRecoveredSigsDb to use it as well.

codablock added 10 commits March 8, 2019 17:34
@codablock
Don't pass CEvoDB to CDKGSessionHandler and CDKGSession
acb52f6 
Was never used.
@codablock
Introduce global llmq::llmqDb instance of CDBWrapper
e2cad1b 
This DB is for LLMQ related data that is not part of on-chain consensus.
This for example included LLMQ secret key shares and recovered signatures.
@codablock
Don't use CEvoDB in CDKGSessionManager and instead use llmqDb
b2cd1db 
Contributions are not part of on-chain consensus and shouldn't be stored in
CEvoDB.
@codablock
Use llmqDb for CRecoveredSigsDb
61e10f6 
Instead of creating its own CDBWrapper internally.
@codablock
Add key prefix to "rs_" for CRecoveredSigsDb keys
43e1bf6 
This avoids future conflicts with other data stored in llmqDb
@codablock
Add HasVotedOnId/GetVoteForId to CSigningManager
d4cf78f 
These just pass through to CRecoveredSigsDb
@codablock
Use GetVoteForId instead of maintaining votes on inputs
f351145
@codablock
Implement unordered_lru_cache
9e4aa1f
@codablock
Use unordered_lru_cache in CRecoveredSigsDb
293c9ad
@codablock
Make InstantSend locks persistent
ac00c66
@UdjinM6 UdjinM6 added this to the 14.0 milestone Mar 11, 2019
UdjinM6
UdjinM6 reviewed Mar 11, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Just a couple of tiny nits, see below.

UdjinM6
UdjinM6 approved these changes Mar 11, 2019
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock merged commit effcd0c into dashpay:develop Mar 12, 2019
@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Jul 18, 2020
@UdjinM6 UdjinM6 modified the milestones: 14.0, 17 Jul 18, 2020
@UdjinM6 UdjinM6 removed the RPC Some notable changes to RPC params/behaviour/descriptions label Jul 18, 2020
@UdjinM6 UdjinM6 modified the milestones: 17, 14.0 Jul 18, 2020
@kwvg kwvg mentioned this pull request Sep 30, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock @UdjinM6 @PastaPastaPasta