Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 25, 2018

Should fix win installer and debian packager logos/images.
This also fixes the script for pngs and slightly minimizes the size of few new images used in qt.

@UdjinM6 UdjinM6 added this to the 12.3 milestone Jun 25, 2018
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Would prefer to add to a point release unless a new rebuild is necessary because functionality or security is compromised.

@UdjinM6
Copy link
Author

UdjinM6 commented Jun 26, 2018

This is needed basically to reduce the number of complains about installer using old logos :) Assuming we are going to prepare "the very final" build anyway due to #2148 bug, I would include this one as well.

@nmarley
Copy link

nmarley commented Jun 26, 2018

@UdjinM6 If #2148 is a bug which affects usability then it might be a good idea. Just trying to prevent re-building via Gitian, re-verifying results from multiple developers and gitian signatures if possible.

@UdjinM6 UdjinM6 merged commit 7ab5b4a into dashpay:develop Jun 28, 2018
@UdjinM6 UdjinM6 deleted the updateimages branch November 26, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants