Drop trigger objects when triggers are deleted or failed to be created #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarley
reviewed
Jun 6, 2018
src/governance-classes.cpp
Outdated
| trigger_m_it it = mapTrigger.begin(); | ||
| while(it != mapTrigger.end()) { | ||
| bool remove = false; | ||
| CGovernanceObject* pObj = NULL; |
There was a problem hiding this comment.
Should we try to use nullptr in these places instead?
Yoyae
pushed a commit
to monacocoin-net/monoeci-core
that referenced
this pull request
Jun 12, 2018
dashpay#2098) * Mark an object for deletion when the corresponding trigger is deleted * Mark objects for deletion if creation of corresponding triggers failed * NULL -> nullptr * Make sure pObj is not null
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
dashpay#2098) * Mark an object for deletion when the corresponding trigger is deleted * Mark objects for deletion if creation of corresponding triggers failed * NULL -> nullptr * Make sure pObj is not null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we are going to have some of these objects (and their votes) in memory forever.