Skip to content

Conversation

@thephez
Copy link
Collaborator

@thephez thephez commented May 3, 2018

  • Adjust some comments so they will be picked up by doxygen
  • Add a few brief descriptions

@thephez
Copy link
Collaborator Author

thephez commented May 3, 2018

Might be nice to gradually update things so doxygen picks them up and also add additional detail on some of the more obscure stuff. Figured I would do something small like this and see what the feedback was...

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

utACK

@UdjinM6 UdjinM6 added this to the 12.3 milestone May 4, 2018
@UdjinM6
Copy link

UdjinM6 commented May 4, 2018

Note: will probably cause some minor merge conflicts for #2040 due to removal of *_INSTANTSEND_DEPTH but should be trivial to resolve.

@thephez
Copy link
Collaborator Author

thephez commented May 4, 2018

Ah, explains my confusion. I thought those had been removed and was surprised to see them still in there. Did not think to check the open PRs. 🙄

Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, Thanks for this! It's nice to get more comments/documentation on these parts of the code.

@UdjinM6 UdjinM6 merged commit ef85d51 into dashpay:develop May 13, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
* [Comment] - Minor Instantx comment updates and additions

* [Comment] - Update to doxygen recognised format
 - Capitalisation changes

* [Comment] - Add some minor InstantSend comments
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 1, 2019
* [Comment] - Minor Instantx comment updates and additions

* [Comment] - Update to doxygen recognised format
 - Capitalisation changes

* [Comment] - Add some minor InstantSend comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants