Fix transaction/block versions for devnet genesis blocks #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56ff71f mistakenly increased the coinbase transaction version instead of the block version. This fixes it.
UdjinM6
reviewed
Apr 30, 2018
src/chainparams.cpp
Outdated
|
|
||
| CMutableTransaction txNew; | ||
| txNew.nVersion = 4; | ||
| txNew.nVersion = 2; |
There was a problem hiding this comment.
v2 started to use the height in coinbase and I wanted to provide the height in the genesis block as well. don't remember however why I wanted this in the first place
There was a problem hiding this comment.
I think you are confusing tx/block version here again then - block v2 (bip34) started to use height, tx v2 is about bip68, not bip34.
There was a problem hiding this comment.
Yeah, you're right. This confusion seems to haunt me...adding a commit on top
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
* Fix transaction/block versions for devnet genesis blocks 56ff71f mistakenly increased the coinbase transaction version instead of the block version. This fixes it. * Use v1 for coinbase transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
56ff71f mistakenly increased the coinbase transaction version instead
of the block version. This fixes it.