Force rcc to use resource format version 1 #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt 5.8.0 introduced format version 2 for resources embedded into executable, and now rcc uses this format by default to generate them. Unfortunately, v2 format includes timestamps for embedded resource files. Some of resource files (translations) are generated automatically and have different timestamps for every build. This means that dash-qt executable is slightly different for every build because resource data contain different timestamps. As a result, it makes reproducible build extremely difficult. Fortunately, Qt 5.9.0 introduced --format-version option for rcc. This change adds configure check for whether rcc accepts this option and uses it to force rcc to generate version 1 format data. Signed-off-by: Oleg Girko <ol@infoserver.lv>
NarubyRiverlione
added a commit
to NarubyRiverlione/spice
that referenced
this pull request
Feb 4, 2018
* 'spice' of github.com:NarubyRiverlione/spice: (8382 commits) updated testnet genessis spice images more rename genesis blocks ports magic message letters start letter addresses cleanup : * remove gitian signatures * remove seeds rename: more originale files rename Prepare 0.12.2.3 release notes (dashpay#1846) Avoid reference leakage in CKeyHolderStorage::AddKey (dashpay#1840) Protect CKeyHolderStorage via mutex (dashpay#1834) Skip existing masternode conections on mixing (dashpay#1833) Merge pull request dashpay#1836 from lodgepole/feature/backport-11847 Fix -liquidityprovider option (dashpay#1829) Vote on IS only if it was accepted to mempool (dashpay#1826) bump version to 0.12.2.3 (dashpay#1827) Merge bitcoin#8256: BUG: bitcoin-qt crash Swap iterations and fUseInstantSend parameters in ApproximateBestSubset (dashpay#1819) Fix crash on exit when -createwalletbackups=0 (dashpay#1810) Prepare v0.12.2.2 release notes (dashpay#1769) Force rcc to use resource format version 1. (dashpay#1784) ... # Conflicts: # contrib/gitian-descriptors/gitian-osx-signer.yml # contrib/gitian-descriptors/gitian-win-signer.yml # src/chainparams.cpp # src/qt/res/icons/bitcoin.icns # src/qt/res/icons/bitcoin.ico # src/qt/res/icons/bitcoin.png # src/qt/res/icons/crownium/about.png # src/qt/res/icons/drkblue/about.png # src/qt/res/icons/drkblue/bitcoin.png # src/qt/res/icons/light/about.png # src/qt/res/icons/light/remove.png # src/qt/res/icons/remove.png # src/qt/res/icons/trad/about.png # src/qt/res/icons/trad/remove.png
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Dec 26, 2018
Qt 5.8.0 introduced format version 2 for resources embedded into executable, and now rcc uses this format by default to generate them. Unfortunately, v2 format includes timestamps for embedded resource files. Some of resource files (translations) are generated automatically and have different timestamps for every build. This means that dash-qt executable is slightly different for every build because resource data contain different timestamps. As a result, it makes reproducible build extremely difficult. Fortunately, Qt 5.9.0 introduced --format-version option for rcc. This change adds configure check for whether rcc accepts this option and uses it to force rcc to generate version 1 format data. Signed-off-by: Oleg Girko <ol@infoserver.lv>
andvgal
added a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt 5.8.0 introduced format version 2 for resources embedded into executable, and now
rccuses this format by default to generate them.Unfortunately, v2 format includes timestamps for embedded resource files.
Some of resource files (translations) are generated automatically and have different timestamps for every build.
This means that dash-qt executable is slightly different for every build because resource data contain different timestamps.
As a result, it makes reproducible build extremely difficult.
Fortunately, Qt 5.9.0 introduced
--format-versionoption forrcc.This change adds configure check for whether
rccaccepts this option and uses it to forcerccto generate version 1 format data.