You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR not only allows unbundling of UniValue library (making packaging easier), but also fixes a bug preventing correct build of bench_dash.
Original description is not completely correct: by default bundled UniValue is used, attempt to detect system one is performed only if --with-system-univalue option is present. Hence, this change is fully backwards-compatible and does not interfere with existing build process.
Original description follows.
If UniValue is present on the system, it will be used instead of bundled copy.
If not, bundled copy will automatically be built and used statically.
User can override either way using --with[out]-system-univalue configure option.
Current Dash benchmark code is quite minimal, but its Makefile.bench.include is supposed to link univalue library in case other benchmarks use other parts of Dash code that use this library. I was playing with some Bitcoin PR that adds another benchmark, and suddenly bench_dash compilation started failing with unresolved symbols. So I found that Makefile.bench.include uses $(LIBBITCOIN_UNIVALUE) in Dash, but it uses $(LIBUNIVALUE) in Bitcoin, so I found that backporting this PR will be beneficial for Dash. For reference, $(LIBUNIVALUE) is used in Makefile.test.include, so what we currently have in Makefile.bench.include is definitely a bug.
Although I've decided not to backport the PR introducing another benchmark I've mentioned above, we can add more benchmarks in the future.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of Bitcoin PR bitcoin#7349.
This PR not only allows unbundling of UniValue library (making packaging easier), but also fixes a bug preventing correct build of
bench_dash.Original description is not completely correct: by default bundled UniValue is used, attempt to detect system one is performed only if
--with-system-univalueoption is present. Hence, this change is fully backwards-compatible and does not interfere with existing build process.Original description follows.
If UniValue is present on the system, it will be used instead of bundled copy.
If not, bundled copy will automatically be built and used statically.
User can override either way using --with[out]-system-univalue configure option.