Skip to content

potential deadlock in spork.cpp #3814

@sidhujag

Description

@sidhujag

https://github.com/dashpay/dash/blob/master/src/spork.cpp#L189

has a potential lock-order-inversion issue.

This is the fix: syscoin@08477e1#diff-0d7c5dba4239c4b6d3be8e7ba142a255b1301fde8c54cb5e0f4979f3d5cc25aeL202

This is the TSAN: https://cirrus-ci.com/task/5590017022099456?command=ci#L3366

You should probably also review other places where inventory is sent from governance classes, it cannot be using local class CS locks there likely I found a couple other places it was affecting too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions