fix: use original icon hash for id

[Syn-McJ]

To maintain compatibility with iOS in the case of uploading icon metadata to the platform, we need to use the same IDs for the icons. Currently, the ID hash is calculated from the resized icon data, while it is nearly impossible to resize the icon in the same way across platforms.

Issue being fixed or feature implemented

• Use the original icon data to calculate ID instead of the resized one.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

• QA (Mobile Team)

Checklist:

• I have performed a self-review of my own code and added comments where necessary
• I have added or updated relevant unit/integration/functional/e2e tests

Summary by CodeRabbit

• Bug Fixes
  • Improved consistency of icon image handling and hashing for transaction metadata across platforms. This ensures more reliable display and identification of transaction icons.

[coderabbitai]

Walkthrough

The updateIcon method in the wallet transaction metadata provider was revised to compute the image hash from the original downloaded image bytes instead of the resized bitmap. The image is then decoded and resized as before, but only the resized image data is stored. Control flow and error handling remain unchanged.

Changes

File(s)	Change Summary
wallet/src/de/schildbach/wallet/service/WalletTransactionMetadataProvider.kt	Modified image download logic: now computes hash from original image bytes, decodes bitmap from bytes, and stores resized image data.

Poem

In the warren where icons hop and play,
We hash from the source, in a brand-new way.
Bytes are counted, resized with flair,
A unified hash—now platforms can share!
Rabbits cheer for images neat,
Hopping along with metadata complete.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d94921 and 6980ecc.

📒 Files selected for processing (1)

• wallet/src/de/schildbach/wallet/service/WalletTransactionMetadataProvider.kt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: check
• GitHub Check: build

🔇 Additional comments (1)

wallet/src/de/schildbach/wallet/service/WalletTransactionMetadataProvider.kt (1)

589-597: LGTM! Excellent fix for cross-platform icon ID consistency.

The changes correctly address the core issue by separating ID generation from storage optimization:

• Hash calculated from original image data ensures consistent IDs across platforms
• Resized image data still used for efficient storage
• Logic flow is clear and maintains existing error handling

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[HashEngineering]

LGTM