Repository navigation
Send Confirmation Dialog: Display calculated fee #55
Description
Activity
@riongull please test this functionality at https://fix-dashwallet-implementation.wallet.dashincubator.dev/ & provide feedback.
Keep in mind this provides extra information without being a final design, no need to criticize the look yet, just focus on the information and quality of it.
It's an improvement but "full amount" is incorrect.
In terms of style I'd make the top line "To recipient(s)", the next line "Network fee" (keep it smaller font), and then "Total" at the bottom.
Subsequent screenshots
- one confirm from above tx
- one addition tx with confirm
@riongull please review this feature/functionality again at https://fix-dashwallet-implementation.wallet.dashincubator.dev/ and change Status to Done if you approve or back to "In Progress" if it needs more work.
I'd like to gray out insignificant figures here like we do in the main balance screen. So for now, make the last 5 digits gray.
After mulling it over, I think we talk with @coolaj86 about potentially changing the significant figures:
- It might be better to split the significant-insignificant digits to 4-4 instead of our current 3-5.
- I'd like the maximum insignificant digit to have less than 1 USD cent of value.
- Right now the max insignificant digit would be 0.000 90000 (highest value of first insignificant figure)
- At the current 40 USD/DASH that is 40 x 0.000 90000 = $0.036 (3.6 cents USD).
- If we shift it one place the max insignificant digit would be 0.0000 9000
- Then even at 100 USD/DASH it would be 100 x 0.0000 9000 = $0.009 (<1 cent USD).
- 4-4 is more significant digits to track mentally, but it's more balanced than 3-5, so I think easier to work with overall.
From testing (and conversations with AJ) it seems the denominated tx handling makes "stamps" of 200 sats each (where each send uses at least 200 sats, sometimes 400 or more, but it seems multiples of 200). When people are using that option it will be easier for them to see a value of 1.0000 5600 and have a better "gut feel" that I can send this 1 DASH 20 or so times without the face value (the significant figure - 1.0000) changing. We'll need to talk this over with @coolaj86, because there are nuances about how the library works that might need to change to facilitate this.
For now just make the simple UI change to gray the last 5 digits. We can copy the above to a new issue to address the bigger change.
- added a commit that references this issue
on Mar 16, 2024 @riongull this is implemented by 668bad3 at https://feat-surface-errors.wallet.dashincubator.dev/.
Closing this issue and setting status to Done.
Metadata
Metadata
Labels
Type
Projects
- Status
We need to display the fee for the transaction and possibly update the amount to what will actually be sent.